Arvados

Review @ 7fb83a33:

• apps/workbench/app/controllers/keep_disks_controller.rb
  • Tricky to understand what's going on, because it looks like the code for generating block-age-free-space-histogram log events is not there yet!
  • Add comments explaining the structure of the @cache_age_histogram array, what it's for and how it's produced: i.e. an array of objects suitable for passing to Morris.Area when renderHistogram is called, and briefly describe the elements of the source histogram array and the objects that it returns.
  • Rename @histogram_date to @histogram_date_ms for clarity about units

Tim Pierce wrote:

Review @ 7fb83a33:

• apps/workbench/app/controllers/keep_disks_controller.rb
  • Tricky to understand what's going on, because it looks like the code for generating block-age-free-space-histogram log events is not there yet!

Sorry, you're right, it's in datamanager on a branch of mine. You can see the running code at:
https://shell.arvados:3001/keep_disks

• Add comments explaining the structure of the @cache_age_histogram array, what it's for and how it's produced: i.e. an array of objects suitable for passing to Morris.Area when renderHistogram is called, and briefly describe the elements of the source histogram array and the objects that it returns.

Added tons of comments. Sorry, I didn't really stop to think about how confusing this would be for another person to read. Part of the problem is the histogram we had in mind changed between when the underlying data was produced and written to the logs and when we came up with something that seems more usable. Eventually I'll go back and clean up the generating code to output what we want, but I wanted to get some eyeballs on the chart first.

• Rename @histogram_date to @histogram_date_ms for clarity about units

done, thanks

Thanks for the comments! This helps a lot.

It took me a bit to feel confident that I understand how this code is using @cache_age_histogram, but I think it makes sense to me now, and if we expect to go back and make the code to generate histogram data a little more sensible then I'm not fussed about it. LGTM.