Project

General

Profile

Actions
Copy link

Task #2832

closed

Bug #2831: arv-mount bugfixes

review 0000-arv-mount-bugfixes

Added by Ward Vandewege almost 12 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Ward Vandewege
Target version:
2014-05-28 Pipeline Factory
Actions
Copy link
 #1

Updated by Brett Smith almost 12 years ago

  • Assigned To changed from Brett Smith to Ward Vandewege

Reviewing 7b4d7fa

Would it be possible to tighten the try block like this?

        try:
            collection = arvados.CollectionReader(arvados.Keep.get(self.collection_locator))
        except Exception as detail:
            print("%s: error: %s" % (self.collection_locator,detail) )
        else:
            for s in collection.all_streams():
                …

That would help make it clearer which part we actually expect to fail. It might be trickier if all_streams could also fail, though.

That's my only comment, so whether you make that change or can't, I think you're good to merge.

Actions
Copy link
 #2

Updated by Ward Vandewege almost 12 years ago

Good point - I think I'd prefer to play it safe and wrap the whole thing in the try/except block. If an exception is triggered there, the fuse driver just dies. That should be avoided, imo. Thanks for the review!

Actions
Copy link
 #3

Updated by Ward Vandewege almost 12 years ago

  • Status changed from New to Resolved
  • Start date set to 05/15/2014
  • Remaining (hours) set to 0.0
Actions
Copy link

Also available in: Atom PDF