Arvados

It appears that tasks_summary sent to _job_progress.html.erb is not populated with the correct values.

#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."

The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.

Brett Smith wrote:

#3034 specifies: "job progress bars reflect at least one task. If a job has no tasks at all (done, failed, finished, or todo) that should be considered a failed job, so render a progress bar as though one task ran and failed."

The code doesn't do that. Instead, it renders a completely empty progress bar (unless the whole job is marked as failed). I believe the implemented behavior is more correct (otherwise we'd render a failure bar for any Job which hasn't even started yet), so I'm fine with that. However, I wanted to flag the discrepancy for attention. If you had the same thought I did, or this implementation is consistent with follow-up discussion not in the ticket, then ee69f70 looks good to merge to me. Thanks.

You're correct, thanks for pointing it out. After submitting the review task, discussion about the desired behavior convinced me that we want an empty progress bar in this case. Going ahead and merging.