Story #3527: [Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" . - Arvados

Actions

Copy link

Story #3527

closed

[Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .

Added by Peter Amstutz over 10 years ago. Updated over 10 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Brett Smith

Category:

Crunch

Target version:

2014-08-27 Sprint

Start date:

08/08/2014

Due date:

% Done:

100%

Estimated time:

(Total: 1.00 h)

Story points:

0.5

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Brett Smith over 10 years ago

Status changed from New to In Progress
Assigned To set to Brett Smith

Actions

Copy link

Updated by Tom Clegg over 10 years ago

Subject changed from Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" . to [Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .
Category set to Crunch

api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.

Other than that, this LGTM

Actions

Copy link

Updated by Brett Smith over 10 years ago

Category deleted (~~Crunch~~)

Tom Clegg wrote:

api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.

As discussed in IRC, crunch-job was assuming that the Docker image would be stored in the '.' stream. I taught it to accept any stream from the Collection, and removed the dirname check from the API server. Please take another look.

Actions

Copy link