Arvados

Reviewing 3762-delete-list-worker fed6d3b

The cached discovery document should part of the ArvadosClient struct, not the DISCOVERY global variable. You should probably fetch the discovery document in MakeArvadosClient().

If you want to return "any type" in Go, you use interface{}. Then Discovery() does not need to create valueMap just to return as single item.

I just realized that having the trashWorker fetch "defaultTrashLifetime" from the discovery document means that we are re-introducing a dependency on the API server that we had just worked to eliminate with the pullWorker. We should consult tom/ward on their preference.

I noticed this in both pullq and trashq:

    if pullq == nil {
        pullq = NewWorkQueue()
    }

trashq and pullq should never be nil, and if they are nil, allocating a new work queue won't do anything because there won't be a worker goroutine associated with it. These tests should be taken out or converted into a assertions that raise an error.

• Removed all the new code for API discovery and instead using permission_ttl. Per our discussion with Tom, defaultTrashLifetime is the same as permission_ttl, which is already available in keepstore and this should be used.

• Removed "if pullq == nil ... " from handlers.go and updated the handler_test instead to create the instances of pullq and trashq.

LGTM