Bug #4026
closed
[Workbench] "Move to project..." button should be displayed to an admin user even if the sub-project is in another user's Home project.
Added by Radhika Chippada over 10 years ago.
Updated over 10 years ago.
Assigned To:
Radhika Chippada
Estimated time:
(Total: 0.00 h)
apps/workbench/app/views/application/_title_and_buttons.html.erb might need revisiting.
- Subject changed from "Move to project..." button is not displayed to an admin user if the project is not owned by the admin user. It should be displayed to admin users. to "Move to project..." button is not displayed to an admin user if the sub-project is in another user's Home project.
- Subject changed from "Move to project..." button is not displayed to an admin user if the sub-project is in another user's Home project. to [Workbench] "Move to project..." button is not displayed to an admin user if the sub-project is in another user's Home project.
- Target version changed from Bug Triage to Arvados Future Sprints
Possible fix in 4026-admin-move-project c64623a
- Target version changed from Arvados Future Sprints to 2014-10-29 sprint
- Subject changed from [Workbench] "Move to project..." button is not displayed to an admin user if the sub-project is in another user's Home project. to [Workbench] "Move to project..." button should be displayed to an admin user even if the sub-project is in another user's Home project.
- Assigned To set to Radhika Chippada
Reviewing 2556bf9
It's possible to simplify this condition by saying if (ArvadosBase.find(@object.owner_uuid).writable_by.include?(current_user.uuid) rescue nil). We just added this last week, but it's great for simplifying permission checks like this: both User and Group return writable_by, and it always includes the requesting user's own UUID if they're an admin. So it's one line that covers all the same cases as this condition.
I'm happy for this branch to be merged with that change, or without if there's some reason it's not appropriate. Thanks.
- Status changed from New to In Progress
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:c6056f6f1bb99fa10bc2046266accc4a85f66aad.
Also available in: Atom
PDF
Updated by Radhika Chippada 
Updated by 
Updated by 
Updated by