Arvados

Observed this issue while testing 4228:

Not only are we getting empty collections when combining files that are in a directory or sub-directory in a collection; we are getting "Not found" errors when such a file is downloaded or viewed.

https://workbench.qr1hi.arvadosapi.com/collections/e8987d293cba82b6618f0412a30c26cf+104/tmp5/yup.txt?disposition=inline&size=4

This can be found in https://workbench.qr1hi.arvadosapi.com/collections/qr1hi-4zz18-w74zrwyvft9q81n

Another such collection: https://workbench.qr1hi.arvadosapi.com/collections/qr1hi-4zz18-74ikz4mn29q3i34

Reviewing f1eb092

I suggest writing the main fix as

file_name = params[:file].andand.sub(/^(\.\/|\/|)/, './')

This version avoids prepending ./ if it's already specified, and writes ./ correctly if params[:file] starts with a /. It does add ./ for the single-file case, but that's okay according to the Keep manifest documentation.

If you're comfortable with this change, I'm happy to see it merged. Thanks.

Thanks Brett. I updated accordingly.