Feature #5645
closed
[Workbench] Social media optimize anonymous collections/projects/pipelines
Added by Nancy Ouyang over 9 years ago.
Updated over 9 years ago.
Assigned To:
Radhika Chippada
Estimated time:
(Total: 0.00 h)
Files
Related issues
1 (1 open — 0 closed)
- Description updated (diff)
- Target version set to Bug Triage
- Subject changed from Social media optimize anonymous collections/projects/pipelines to [Workbench] Social media optimize anonymous collections/projects/pipelines
- Category set to Workbench
- Target version changed from Bug Triage to Arvados Future Sprints
- Target version changed from Arvados Future Sprints to 2015-05-20 sprint
- Assigned To set to Radhika Chippada
Discussed this with Ward this morning and we agreed that:
- Add open graph meta tags to our pages
- Add these tags for all objects (since the search engine won't be able to access private data anyways)
Implementation notes:
- Also, manually verified by looking at the loaded page html
- All existing automated tests passed
- Status changed from New to In Progress
1be4d28 is good to merge. I just see a couple of small opportunities to smooth things over for future readers:
- Expounding the comment about Open Graph with a sentence or two about what it is and why we include it us might be useful for people who don't recognize the name. (I'm not sure I would've known without being able to refer to the background materials you provided in this ticket. Those were very helpful, so thanks.)
- Why do the conditions rescue exceptions raised by
@object.respond_to?
. respond_to?
is a method that Ruby defines for all objects, so it really should never raise an exception, and I don't see any other places in the Workbench code where we rescue it. These conditions might be easier to follow without those.
But go ahead and merge whether or not you make changes. Thanks.
Thanks for reviewing Brett.
- I expanded the comment to include the feature number and the url, which should greatly help with code maintenance.
- I removed the "rescue nil" from respond_to? usage.
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:01574a902d99cba21ed53e62cef6bef683bed2a2.
From the sprint review a week ago: we could also consider adding either user-upload(able) "thumbnail" images to the collection/project, or perhaps try to generate one automatically (e.g. the curoverse logo, or some permutation of text on top of the logo with the title or size of the collection or something along those lines) or by default if the user does not select or upload an image.
Also available in: Atom
PDF