Project

General

Profile

Actions

Bug #7308

closed

arv-git-httpd tests don't say what tests they are running

Added by Joshua Randall over 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
-
Story points:
-

Description

It would be useful if the arv-git-httpd tests would say what they are doing so that when they aren't working, we know where to look.

Currently (after applying a local fix for #7307), the output of these tests starts with:

           ********** Running services/arv-git-httpd tests **********

fatal: 'git.zzzzz.arvadosapi.com/test': aliased
2015/09/11 10:43:13 authSettings: map[ARVADOS_API_TOKEN:4axaw8zxe0qm22wa6urpp5nskcne8z88cvbupv653y1njyi05h ARVADOS_API_HOST:0.0.0.0:42415 ARVADOS_API_HOST_INSECURE:true]
2015/09/11 10:43:16 "[::1]:43714" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:16 "[::1]:43715" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:16 "[::1]:43715" "3kg6k6lzmp" 200 "read" "active/foo" "GET" "/zzzzz-s0uqq-382brsig8rp3666.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36725" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36728" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36728" "4kg6k6lzmp" 404 "not found" "active/foo" "GET" "/active/foo.git/info/refs" 

From this it is not clear which test is being run. It would be useful if it was something more like:

           ********** Running services/arv-git-httpd tests **********

2015/09/11 10:43:11 git_handler_test: TestCGIError()
fatal: 'git.zzzzz.arvadosapi.com/test': aliased
2015/09/11 10:43:11 git_handler_test: TestEnvVars()
2015/09/11 10:43:13 authSettings: map[ARVADOS_API_TOKEN:4axaw8zxe0qm22wa6urpp5nskcne8z88cvbupv653y1njyi05h ARVADOS_API_HOST:0.0.0.0:42415 ARVADOS_API_HOST_INSECURE:true]
2015/09/11 10:43:16 "[::1]:43714" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:16 "[::1]:43715" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:16 "[::1]:43715" "3kg6k6lzmp" 200 "read" "active/foo" "GET" "/zzzzz-s0uqq-382brsig8rp3666.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36725" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36728" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 10:43:19 "[::1]:36728" "4kg6k6lzmp" 404 "not found" "active/foo" "GET" "/active/foo.git/info/refs" 
Actions #2

Updated by Joshua Randall over 10 years ago

  • % Done changed from 0 to 90
Actions #3

Updated by Joshua Randall over 10 years ago

  • Assigned To set to Joshua Randall
Actions #4

Updated by Joshua Randall over 10 years ago

PR 26 retracted.

Alterative PR proposed for arvados-dev (making go test somewhat verbose by default, which brings it in line with tests in other languages): https://github.com/curoverse/arvados-dev/pull/3

Go tests can still be made extremely verbose by passing `-check.vv` as an app-specific option to run-tests.

Actions #5

Updated by Brett Smith over 10 years ago

  • Status changed from New to In Progress
Actions #6

Updated by Tom Clegg over 9 years ago

  • Status changed from In Progress to Resolved
$ run-tests.sh ... services/arv-git-httpd_test=-check.vv
...
START: git_handler_test.go:45: GitHandlerSuite.TestCGIErrorOnSplitHostPortError
2016/12/14 10:21:14 Internal error: SplitHostPort(r.RemoteAddr=="test.bad.address.missing.port"): missing port in address test.bad.address.missing.port
PASS: git_handler_test.go:45: GitHandlerSuite.TestCGIErrorOnSplitHostPortError  0.000s

START: git_handler_test.go:16: GitHandlerSuite.TestEnvVars
PASS: git_handler_test.go:16: GitHandlerSuite.TestEnvVars       0.005s

START: <autogenerated>:20: GitoliteSuite.SetUpSuite
2016/12/14 10:21:15 authSettings: map[ARVADOS_API_TOKEN:4axaw8zxe0qm22wa6urpp5nskcne8z88cvbupv653y1njyi05h ARVADOS_API_HOST:0.0.0.0:46485 ARVADOS_API_HOST_INSECURE:true]
PASS: <autogenerated>:20: GitoliteSuite.SetUpSuite      1.506s
...
Actions

Also available in: Atom PDF