Idea #8057
closed
[Workbench] Fix and restore test "load pane with deleted session"
Description
'load pane with deleted session' worked for a long time, then started failing a lot (but not always)
Skipped test 'load pane with deleted session' in 38b15ad14b941e8935bdfae3ddcdb83f7d8e20af
Then 'load pane with expired token' started failing instead.
Skipped test 'load pane with expired token' in fea7d51546b51261b962daa0ca534ddf7c257409
Updated by Brett Smith over 10 years ago
- Category set to Workbench
This is in test/integration/ajax_errors_test.rb. After we upgraded Jenkins from Iceweasel 31 to 38, it started failing as often as not, rendering nothing where we expected the error to be. Find another way to test this behavior reliably, and stop skipping the test.
Updated by Radhika Chippada about 10 years ago
Do these two tests need to be ajax error tests? That is, can these tests do: access a page; expire / delete token; access another page such as '/' ; verify login page is shown? I ask because doing so might help test the exact expired / deleted token behavior, without worrying about ajax testing related issues. (If we do this, we might want to consider moving the tests into a different file such as application_layout_test).
Updated by Tom Clegg about 10 years ago
Yes, these have to be AJAX tests. XHRs have different error handling than regular page loads (both in the browser and in Workbench itself). We added these tests when fixing an XHR-specific session bug -- see #5105.
(There's a non-AJAX "expired token" test in source:apps/workbench/test/integration/errors_test.rb and a bunch of tests that rely on AJAX, none of which are flaky, so it seems like the bug is somewhere in the intersection of AJAX and handling of bad tokens.)
Updated by Peter Amstutz