Bug #8413
closed
[Deployment] Rails postinst script apparently messes with /etc/arvados directory tree ownerships
100%
Description
On one system it changed the owning group to root where it should've stayed www-data.
Updated by Brett Smith almost 9 years ago
- Target version set to 2016-03-02 sprint
Updated by Brett Smith almost 9 years ago
- Status changed from New to In Progress
Updated by Nico César almost 9 years ago
review @ b6488e3814aea0a97a6912ffb92327030df69e63
LGTM
it got my attention that you switched from logical names to UID/GID
- local ownership="$(stat -c "%U:%G" "$release_conffile")"
+ local ownership="$(stat -c "%u:%g" "$release_conffile")"
was that a safe guard for non-listed users in /etc/groups (a.k.a some docker related problem :) )? this is just curiosity, you should merge
Updated by Brett Smith almost 9 years ago
Nico Cesar wrote:
it got my attention that you switched from logical names to UID/GID
- local ownership="$(stat -c "%U:%G" "$release_conffile")"
+ local ownership="$(stat -c "%u:%g" "$release_conffile")"
was that a safe guard for non-listed users in /etc/groups (a.k.a some docker related problem :) )? this is just curiosity, you should merge
It was to make the gid comparison later in the code easier. It was easier to say [ 0 != "$owning_gid" ] than look up the name of GID 0 and compare. Thanks.
Updated by Brett Smith almost 9 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-dev|commit:623af8e46e921f59abeeee9e7ae8ec4aef890b5b.