Arvados

Jonathan,

The fix for #4088 is deployed, which I hope will resolve your issues. Can you please compare a couple of pipelines and see if you believe there are any outstanding issues?

Thanks.

Mmm, the link I provided in the bug is definitely prettier, but doesn't seem to actually be comparing... Can Bryan test?

https://workbench.qr1hi.arvadosapi.com/pipeline_instances/compare?uuids%5B%5D=qr1hi-d1hrv-pep5f13gwh50paf&uuids%5B%5D=qr1hi-d1hrv-f651o1m7hmxv1ci#Graph

I think the problem being reported is that you can't tell which jobs/outputs are part of pipeline A and which are part of pipeline B: every node in the graph is green.

Comments from Tom:

Basically you run a pipeline, then you run it again with some
parameter changed, and you see whether that actually changed your
outputs. Or: you don't remember which parameter/input you changed, so
you compare the two pipelines and it's obvious from the graph where
the two versions start to diverge.

https://workbench.qr1hi.arvadosapi.com/pipeline_instances/compare?uuids%5B%5D=qr1hi-d1hrv-z5hd2sylqsc9e9k&uuids%5B%5D=qr1hi-d1hrv-3wr2iqiq9xgs9cr#Graph

On the "compare" tab you can see the verifyBamID component is
different in some way. This should be apparent on the graph as well:
there should be two distinct graph nodes representing verifyBamID
jobs, and they should be coloured differently than the rest of the job
nodes (all of which are equivalent in the two pipelines).

(This used to work -- there was a legend "pipeline A, pipeline B,
both" -- but currently it looks like it's been lost completely.)

4358-graph-not-comparing @ 84b8801 looks good. Example in note-3 renders properly for me. Please merge.

I think we should add a test case before closing the issue, though. (Can we search the SVG graph with the usual Capybara finders, or is this going to get complicated on us?)

Okay I've merged to master and added a new task for that test...